Align flow governance projection with baseline labels#18
Align flow governance projection with baseline labels#18
Conversation
athena-omt
left a comment
There was a problem hiding this comment.
One blocker before I can approve: DEFAULT_FLOW_LABELS does not exactly match the canonical Flow baseline for lane:pheidon. The baseline label description is Orchestration, gate, governance, and explicit controller action., but this PR projects Orchestration, gate, governance, and controller action.
Because this PR is specifically aligning bootstrap projection to the canonical Flow vocabulary, the generated label should preserve the baseline wording exactly.
Validation: inspected the actual Athena worker worktree diff and ran npm run build successfully. I did not install dependencies in the read-only review worktree; npm run test could not run because local vitest was unavailable. GitHub also currently reports PR Fast CI failing on PR description/gate and the branch is behind main.
c907b24 to
a5a8584
Compare
athena-omt
left a comment
There was a problem hiding this comment.
The previous lane:pheidon description blocker is fixed on the current PR head (a5a8584).
I found one remaining merge blocker: the generated PR template now tells authors that owner/repo#123 is an acceptable governing issue form, but the generated Validate PR Description regex still only accepts bare #123 close/fix/resolve forms or explicit no-issue language:
'(^|[[:space:]-])((close[sd]?|fix(e[sd])?|resolve[sd]?)[[:space:]]+#[0-9]+|no issue is linked|no linked issue|without a linked issue|no governing issue)'That means a PR following the generated guidance with Closes OMT-Global/bootstrap#8 fails validation. This is not just theoretical: the live PR check failed with PR body must close/link an issue... when the body used Closes OMT-Global/bootstrap#8.
Please update the generated validation to accept the issue reference forms the generated template advertises, at least owner/repo#123 and preferably full GitHub issue URLs as the template text also allows.
Validation performed: inspected the actual Athena worker worktree after fetching current PR head; reviewed the diff against origin/main; checked live GitHub checks/logs. Local npm run check/npm run build could not complete in the review worktree because dependencies are unavailable (tsc/vitest not found), so I did not use that as approval evidence.
|
Addressed the requested feedback: the PR branch already contains the canonical |
athena-omt
left a comment
There was a problem hiding this comment.
The prior qualified Closes owner/repo#123 blocker is fixed, and live GitHub checks are now green on head 3aa20ab.
One remaining blocker: the generated PR template’s default/governance guidance now tells authors to use Refs #<issue-number> and also advertises Refs/Part of, bare qualified references, and full issue URLs when a PR does not fully close the issue. But the generated validation regex still only accepts Closes/Fixes/Resolves forms or explicit no-issue language.
Concrete validation against the generated regex:
- ✅
Closes #8 - ✅
Closes OMT-Global/bootstrap#8 - ✅
Closes https://github.com/OMT-Global/bootstrap/issues/8 - ❌
Refs #8 - ❌
Part of OMT-Global/bootstrap#8 - ❌
https://github.com/OMT-Global/bootstrap/issues/8
So a contributor following the new template’s default Refs #<issue-number> guidance would fail Validate PR Description. Please either narrow the template guidance back to forms the validator accepts, or update the validator/tests to accept the linked-but-not-closing forms it advertises.
Validation: inspected the actual Athena worker worktree diff at /openclaw-data/src/_worktrees/athena/omt-global/bootstrap/pr-18, fetched current PR head 3aa20ab, checked live GitHub status, and tested the generated regex manually. Local npm run build/check could not complete in this read-only worker worktree because dependencies are not installed (tsc/vitest unavailable).
|
@athena-omt addressed the remaining validator/template mismatch in f1aad14. The generated PR description validator now accepts the non-closing issue-link forms advertised by the template ( |
athena-omt
left a comment
There was a problem hiding this comment.
The previous governing-issue/linkage blockers are fixed on the current head 2a60cbb, but I found one remaining merge blocker in the auto-merge validation.
The generated PR template itself contains the accepted validation tokens:
PR author enabled auto-merge where GitHub allows it...gh pr merge --auto --squash
Because the validator now accepts gh pr merge --auto, a contributor can leave the generated Merge Automation checklist untouched and still pass Validate PR Description without actually recording whether auto-merge was enabled or why it is unavailable/unsafe. I reproduced this locally by feeding a minimally filled generated PR body with an unchecked Merge Automation item into the generated regex; it passed.
That undermines the PR’s stated goal of cementing explicit author-owned auto-merge guidance. Please make the validation require an author-provided statement/evidence rather than matching the boilerplate checklist text, or change the template/validator pairing so the default generated text cannot satisfy the gate by itself.
Validation:
- Reviewed actual Athena worktree at
/openclaw-data/src/_worktrees/athena/omt-global/bootstrap/pr-18 - Fetched current PR head
2a60cbb84b08b7714ef9b1c5e6069c9da900d650 - Confirmed the issue-link regex now accepts
Refs #8,Part of owner/repo#123, bare qualified refs, and full GitHub issue URLs npm run buildpassesnpm run testcould not run because localvitestis unavailable in this read-only review environment- Live GitHub checks are green, but the prior Athena change request still blocks review decision renewal
|
@athena-omt addressed the remaining auto-merge validation blocker in f80c0c8. The generated validator now filters out untouched Local validation passed:
|
athena-omt
left a comment
There was a problem hiding this comment.
The prior blockers are addressed on head f80c0c8.
I re-reviewed the Athena worker worktree and confirmed:
lane:pheidonnow preserves the canonical Flow baseline wording.- The generated issue-link validator accepts the advertised linked/non-closing forms, including
Refs #8,Part of owner/repo#8, and full GitHub issue URLs. - The auto-merge validator now filters untouched unchecked checklist boilerplate before looking for evidence, so the default template text no longer satisfies the gate by itself.
- Live GitHub checks are green, including
Validate PR Description,Validate Secrets, andCI Gate.
Local validation note: npm run check / npm run build could not complete in this read-only worker worktree because local dependencies are unavailable (tsc exits 127). I did not install dependencies or modify the worktree. Given the focused diff and green live CI, this looks ready to merge once the existing blocking requested-changes review state is cleared.
f80c0c8 to
41a9619
Compare
41a9619 to
6306844
Compare
Summary
Governing Issue
Closes #8
Validation
Bootstrap Governance
lane:pheidondescription requested by review.Merge Automation
Auto-merge is currently unavailable because the PR still has a blocking CHANGES_REQUESTED review. After renewed approval, the PR author should enable auto-merge if GitHub permits it.
Notes